commit ed63ef077a8f6d95dd9038ca0503e8372144010a
author William Wilgus <me.theuser@yahoo.com> Sat Dec 08 01:44:34 2018 -0600
committer William Wilgus <me.theuser@yahoo.com> Sat Dec 08 20:30:12 2018 +0100
tree eb609510c1a4387b26a0a2c92a5393cd5dd1f148
parent 78b2d135671c798dbbc36086cbbf278038d34669

Fix overlapping string region ape.c->read_ape_tags

Switch to strrchr to find the extension

Change-Id: Id7ea01ecc2e0553f560308f8b0fc53bd33b023e5

lib/rbcodec/metadata/ape.c

diff --git a/lib/rbcodec/metadata/ape.c b/lib/rbcodec/metadata/ape.c
index 1460e4a..d6457ea 100644
--- a/lib/rbcodec/metadata/ape.c
+++ b/lib/rbcodec/metadata/ape.c
@@ -124,7 +124,7 @@
                     return false;
                 }
 
-                if (!strcasecmp(name, "cuesheet"))
+                if (strcasecmp(name, "cuesheet") == 0)
                 {
                     id3->has_embedded_cuesheet = true;
                     id3->embedded_cuesheet.pos = lseek(fd, 0, SEEK_CUR)-item.length;
@@ -152,17 +152,24 @@
                     }
 
                     /* Gather the album art format from the pseudo file name's ending. */
-                    strcpy(name, name + strlen(name) - 4);
+                    /* strcpy(name, name + strlen(name) - 4); */
                     id3->albumart.type = AA_TYPE_UNKNOWN;
-                    if      (strcasecmp(name, ".jpg") == 0)
+                    char *ext = strrchr(name, '.');
+                    if (ext)
                     {
-                        id3->albumart.type = AA_TYPE_JPG;
+                        if      (strcasecmp(ext, ".jpg") == 0)
+                        {
+                            id3->albumart.type = AA_TYPE_JPG;
+                        }
+                        else if (strcasecmp(ext, ".jpeg") == 0)
+                        {
+                            id3->albumart.type = AA_TYPE_JPG;
+                        }
+                        else if (strcasecmp(ext, ".png") == 0)
+                        {
+                            id3->albumart.type = AA_TYPE_PNG;
+                        }
                     }
-                    else if (strcasecmp(name, ".png") == 0)
-                    {
-                        id3->albumart.type = AA_TYPE_PNG;
-                    }
-
                     /* Set the album art size and position. */
                     if (id3->albumart.type != AA_TYPE_UNKNOWN)
                     {