Gitiles
Code Review Sign In
gerrit.rockbox.org / rockbox / 1b4135ec0d572f0e85421051cc855be7c5e516e7 / apps / playback.c
  1. 1b4135e Should use HAVE_RECORDING, not AUDIO_HAVE_RECORDING in playback.c by Michael Sevakis · 12 years ago
  2. 344b9d0 Some corrections after 5857c44. by Michael Sevakis · 12 years ago
  3. 5857c44 Refactor audio thread to run both recording and playback. by Michael Sevakis · 12 years ago
  4. 0de2a85 Change audio_set_cuesheet parameter from int to bool (fixes cppcheck warning) by Bertrik Sikken · 12 years ago
  5. 652b39b More snafu fix. Need a couple more patchups for now. by Michael Sevakis · 13 years ago
  6. 0ebfb93 Fix some lockup caused by handles not being initialized to < 0... by Michael Sevakis · 13 years ago
  7. da6cebb Use buflib for the allocation of voice PCM resources. by Michael Sevakis · 13 years ago
  8. 4bef502 rbcodec refactoring: autoresumable by Sean Bartell · 13 years ago
  9. fe3d580 rbcodec refactoring: get_audio_base_data_type by Sean Bartell · 14 years ago
  10. 82337dd buflib/shrink_callback: Resume playback only if it was playing (not paused). by Thomas Martitz · 13 years ago
  11. be10817 Option to constrain get_next_dir() to directories below global_settings.start_directory. by Nick Peskett · 13 years ago
  12. 63c4ef9 Rename 'mp3entry.embed_albumart' to 'mp3entry.has_embedded_albumart' (FS#12470). No functional changes. by Alexander Levin · 13 years ago
  13. 02fd314 FS #12419 : Support for embedded cuesheets. by Nick Peskett · 13 years ago
  14. 8e6030c FS#12378 : Remove various unused code, and comment out some unused code and data for reference or future use. by Boris Gjenero · 13 years ago
  15. 1645c14 Simulate usb plugging on the sim better using sim_tasks. by Thomas Martitz · 13 years ago
  16. 2a8eacd Buflib: Make shrinking and buflib_available() smarter. by Thomas Martitz · 13 years ago
  17. 79ffd04 Fix warning and typos. by Thomas Martitz · 13 years ago
  18. d7e1070 Fix FS#12279 - playback starts from the beginning when changing themes. by Thomas Martitz · 13 years ago
  19. cf01d23 In the playback buflib shrink callback, ensure a minimum buffer remains for by Thomas Martitz · 13 years ago
  20. 57304d1 Make a few local functions static by Bertrik Sikken · 13 years ago
  21. 4c5f5ef Revert r30480 "Buflib/swcodec: Improve playback stopping behavior on allocation." by Thomas Martitz · 13 years ago
  22. 87daeae Buflib/swcodec: Improve playback stopping behavior on allocation. by Thomas Martitz · 13 years ago
  23. 4db3e89 Shuffle some functions around so that interfacing with playback.c in particular isn't required. Though playback does finish the audio init, pcm doesn't care who does it. by Michael Sevakis · 13 years ago
  24. 6d3a6f7 Remove obsolete init cruft from audio system because of diminished dependencies. All talk/voice dependency in playback.c should be imminently removable. by Michael Sevakis · 13 years ago
  25. c1ae789 Fix red. by Andree Buschmann · 13 years ago
  26. baa070c GSoC/Buflib: Enable compaction in buflib. by Thomas Martitz · 13 years ago
  27. d0b72e2 GSoC/Buflib: Add buflib memory alocator to the core. by Thomas Martitz · 13 years ago
  28. 7ad2cad Commit work started in FS#12153 to put timing/position information in PCM by Michael Sevakis · 13 years ago
  29. 89ee922 Remove a slightly silly null dereference. (a.k.a. I'm playing with cppcheck too.) by Steve Bavin · 13 years ago
  30. 5078d46 Fix FS#12238 - WPS delay on pause introduced by r30097 which was the excuse I wanted anyway to do a better PCM fade on stop/pause implementation. New fade is asynchronous tick-based. Restores skin update points in the WPS that were removed when fading mechanism was changed. by Michael Sevakis · 13 years ago
  31. c3e5625 Fix FS#12234 - Simulator crashes when playing mp3 file with cuesheet. The cuesheet in a lookahead mp3entry should not be taken to be valid, since it won't be the cue for the current track. Be sure id3->cuesheet is set NULL if grabbing the info from the buffer. by Michael Sevakis · 13 years ago
  32. d1322b7 GSoC/Buflib: Replace all direct accesses to audiobuf with buffer API functions. by Thomas Martitz · 13 years ago
  33. 94b4a8b revert r30226, which is apparently broken. by Frank Gevaerts · 14 years ago
  34. 92b392e Reload the current playlist after reboot even if it has ended. (FS#11644) by Frank Gevaerts · 14 years ago
  35. a802eba The voice PCM buffer has nothing to do with the playback PCM buffer any longer. Allocate it independently from the playback engine's PCM buffer and only when voice is required. Additionally, allocate actual space for the crossfade buffer only when using crossfade. Will save 18.3KB when neither is needed (10.3KB for voice and 8.0KB for crossfade). by Michael Sevakis · 14 years ago
  36. 5663e1c Have mpegplayer use the mixer (the playback channel, since it's mutually exclusive to audio playback) so the clicks and skip beep can be used according to user settings. Introduce some system sound functions to make easier playing event sounds from various places and convert files calling 'beep_play' to use 'system_sound_play' and 'keyclick_click'. Event sound could be become themeable. by Michael Sevakis · 14 years ago
  37. a2b6703 Commit FS#12150 - Fully-functional audio mixer - and finally whip old limitations about playback of voice and other sounds when paused. Channels are independent in state and amplitude. Fade on stop/pause is handled by the channel's volume control rather than global volume which means it now works from anywhere. Opens up the possibility of plugin sounds during music playback by merely adding an additional channel enum. If any PCM drivers were not properly modified, see one of the last comments in the task for a description of the simple change that is expected. Some params are tunable in firmware/export/pcm-mixer.h as well. by Michael Sevakis · 14 years ago
  38. caf907e Workaround an occasional problem where album art or cuesheets might not be ready by the time the track change event is send which can result in the WPS not immediately being aware that the handles are ready. A better solution will be sought that hopefully doesn't require the additional event. by Michael Sevakis · 14 years ago
  39. 89e791c Fix FS#12118 - Voice UI has issues talking various issues in menus and in the file browswer. audio_pcmbuf_may_play should check play_status for !=PLAY_PAUSED, not ==PLAY_PLAYING so that PCM may auto-start when voicing out playback state. by Michael Sevakis · 14 years ago
  40. 8cb4b36 Fix whitespace and some comment typos by Jeffrey Goode · 14 years ago
  41. a089b00 Hopefully fix red from r29785 - an #ifdef AB_REPEAT_ENABLE was left out. by Michael Sevakis · 14 years ago
  42. c537d59 Commit FS#12069 - Playback rework - first stages. Gives as thorough as possible a treatment of codec management, track change and metadata logic as possible while maintaining fairly narrow focus and not rewriting everything all at once. Please see the rockbox-dev mail archive on 2011-04-25 (Playback engine rework) for a more thorough manifest of what was addressed. Plugins and codecs become incompatible. by Michael Sevakis · 14 years ago
  43. 39d9d8b Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api. by Andree Buschmann · 14 years ago
  44. 4df825b Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...). by Andree Buschmann · 14 years ago
  45. 3184cbe Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track. by Andree Buschmann · 14 years ago
  46. 9c41252 Fixed a typo. (Thanks Jeff!) by Björn Stenberg · 14 years ago
  47. e50cc0e Listen to and follow external Android volume changes. (Based on FS#11914 by Maurus Cuelenaere) by Björn Stenberg · 14 years ago
  48. 7d2ab2d Remove malloc_buf references from playback.c since it's no longer used for anything and align the codec slack space buffer that is now use as the malloc buffer. by Michael Sevakis · 14 years ago
  49. 7df5ecc autoresume: Optimize playlist resume (manual, bookmark, or after power-on) by Michael Hohmuth · 14 years ago
  50. 6510973 Give playback engine better control over the codec. Codec simply follows commands and doesn't concern itself with audio state. Get track change notification in on the actual last buffer insert of the track because now audio simply waits for a track change notify from PCM on the last track and it must be sent reliably. This is still at an intermediate stage but works. Codecs and plugins become incompatible. by Michael Sevakis · 14 years ago
  51. efba46f FS#11933: Check for external album art if embedded album art fails to load. by Magnus Holmgren · 14 years ago
  52. bdec638 Always do proper mp3entry copying instead of using bufread directly. Add bufreadid3() helper. by Michael Sevakis · 14 years ago
  53. edfff8a audio_peek_track should copy the struct mp3entry instead of pointing directly into the buffer. Despite the dire warning, caller does in fact yield/sleep and its usage is too nonlocalized to control that reliably. by Michael Sevakis · 14 years ago
  54. 86cab2e Disable buffering codecs (and code generally) on RaaA. by Thomas Martitz · 14 years ago
  55. f577a6a Embedded album art support in MP3/ID3v2 tags. by Thomas Martitz · 14 years ago
  56. 7141ff4 Add option to resume next track on automatic track change by Michael Hohmuth · 14 years ago
  57. 4844142 Do not update resume information and do not log statistics when a by Michael Hohmuth · 14 years ago
  58. 66e8fc0 Commit part of FS#11748 by Michael Hohmuth. Adds support for automatically resuming any song that is not played to completion at any point later in time, regardless of how many intermediate tracks are played. This is accomplished by expanding the database to record incompletely played tracks. Currently, the feature is simply on or off, in which case all tracks automatically resume, or they do not. The remainder of patches in the task expand this feature by allowing only certain file to automatically resume, only resuming in certain circumstances, etc but are not included until we reach agreement on what should be included. Additionally, the manual will need to be updated once we agree on the available settings. by Michael Giacomelli · 14 years ago
  59. 3dc5f59 Accept FS#11721 by Michael Hohmuth by Jonathan Gordon · 14 years ago
  60. 589490c don't cast to int when not needed by Rafaël Carré · 14 years ago
  61. 99207d6 panicf() is declared in panic.h by Rafaël Carré · 14 years ago
  62. 6340283 audio_reset_buffer: check audiobuffer size not only in DEBUG builds by Rafaël Carré · 14 years ago
  63. 113764d Fix FS#11175. playlist_peek() wasn't thread safe (due to a static filename buffer), so frequent calls from the main thread would cause the audio thread to buffer the wrong track. by Magnus Holmgren · 15 years ago
  64. 2494afc playback.c: don't assume cacheline size is 16 bytes by Rafaël Carré · 15 years ago
  65. 35e8b14 Rockbox as an application: Replace many occurences of #ifdef SIMULATOR with #if (CONFIG_PLATFORM & PLATFORM_HOSTED) (or equivalently). by Thomas Martitz · 15 years ago
  66. b8d98fc Change cuesheet handling so the id3 info is not spoofed anymore. If something wants the subtracks info it is easy to get to. This makes next track display in the skins show the next subtrack if we are in a cuesheet by Jonathan Gordon · 15 years ago
  67. 7d5e0d7 FS#11263 - Radio Art support! %C and %Cl tags work in the radio screen and Base Skin when the radio is running. by Jonathan Gordon · 15 years ago
  68. 1bd072c FS#10853 - Skin support in the radio screen! Check CustomWPS for the new tags by Jonathan Gordon · 15 years ago
  69. d38093d FS#11099 - Rewind before resume by Magnus Holmgren · 15 years ago
  70. 6c175ef drop the playlist viewer stack usage by reading straiught off the buffer instead of copying it. by Jonathan Gordon · 15 years ago
  71. c736696 Minor clean up in playback.c by Andree Buschmann · 15 years ago
  72. c18e80e Implement resume for alac codec. by Andree Buschmann · 15 years ago
  73. 75e105a Make the buffer low-level watermark (and the related anti-skip setting) work again. Update the buffering 'base handle' as new tracks start playing, since this is needed to determine how much playable data is left in the buffer. Should fix the buffering problem reported in the forums (http://forums.rockbox.org/index.php?topic=24014.0), and also makes the usefl line in the buffering thread debug screen useful again. by Magnus Holmgren · 15 years ago
  74. df79ac2 Fix FS#11004 - Buffering crashes when skipping back from end of song. by Thomas Martitz · 15 years ago
  75. fea4689 Get rid of those horrible macros to protect against NULL reference when looking up the id3 info for tokens. by Jonathan Gordon · 15 years ago
  76. dc0ba91 FS#10898 - Add a playlist viewer to the WPS. http://www.rockbox.org/wiki/CustomWPS#Playlist_viewer for an exaplanation how to use it. by Jonathan Gordon · 15 years ago
  77. ecd9bcf Commit FS#10605 - stable playback on low memory swcodec targets by Matthias Schneider. Should allow stable playback on targets with less then 4MB of RAM and sofware decoding such as the Sandisk Clip, c200v2, m200v4 and probably others. Fixes several problems in buffering that occured when the files to be buffered weren't much smaller then the ring buffer size. Fixes a bug where move_handle would corrupt the audio buffer when trying to copy a handle that both wrapped around the highest address in the ring buffer and overlapped part of the source and desination ranges. Moves the decision in playback.c about when to update the current track handle from audio_check_new_track to after the metadata has been buffered. Corrects several other minor pieces of code. I've logged about 100 hours without a crash on various players with this patch but its possible it breaks some combination of players and features I haven't thought to test. by Michael Giacomelli · 15 years ago
  78. db82be4 Cleanup audio.h, related functions by Jeffrey Goode · 15 years ago
  79. ba9280d pcmbuf cleanup by Jeffrey Goode · 15 years ago
  80. 664dc90 Crossfade: added a new option, rewrote decision logic, updated manual and menus. Translators please note that updated translations may be required for some crossfade menu items! by Jeffrey Goode · 15 years ago
  81. 9e09534 Crossfade: carved out crossfade related code with lots of HAVE_CORSSFADE conditionals, eliminated fade buffer on low memory targets by Jeffrey Goode · 15 years ago
  82. 20db9cc Playback: removed duplicate functions by Jeffrey Goode · 15 years ago
  83. 04b01e1 pcmbuf: clarify and simplify crossfade code, etc. by Jeffrey Goode · 15 years ago
  84. 5ce8e2c Clarify track transition code in pcmbuf and playback. No functional changes yet. by Jeffrey Goode · 15 years ago
  85. 8f04d5a Playback.c: Eliminate repetitive watermark calculation when the buffer is idle. Also fix evil comment by Jeffrey Goode · 15 years ago
  86. 5822259 Tweak logf statements by Jeffrey Goode · 15 years ago
  87. e8eefe9 Code cleanup in codec_thread, playback and pcmbuf; more elegant solution to leftover samples by Jeffrey Goode · 15 years ago
  88. 03c5cb6 Fix yellow, defines by Jeffrey Goode · 15 years ago
  89. 9a4420b FS#10739: playback.c code split by Jeffrey Goode · 15 years ago
  90. 774bacc Correct wrong usage of event callbacks all over the place. It's not supposed to return anything, and should take a data parameter. by Thomas Martitz · 15 years ago
  91. 1016ee4 Initial custom statusbar commit. by Thomas Martitz · 15 years ago
  92. e9c1018 Rework albumart buffering internally to allow for mutliple albumart sizes. by Thomas Martitz · 15 years ago
  93. 6bfce3b Remove unused defines by Maurus Cuelenaere · 15 years ago
  94. 0307cd1 Remove some unused #includes by Bertrik Sikken · 16 years ago
  95. 3b75c86 A bit mroe wps/skin engine cleanup so that the structs the wps uses can be static: by Thomas Martitz · 16 years ago
  96. 5f5d105 Change the naming scheme for codecs found in different containers. by Mohamed Tarek · 16 years ago
  97. e96da7e Get cuesheets working again (hopefully fixes FS#10460), on swcodec only read the cuesheet from the buffer once by Jonathan Gordon · 16 years ago
  98. c46669a fix FS#10453 - the cuesheet changes broke playback on swcodec, rework it so it uses the audio buffer instead of a temp buffer from the start (which also removes one pretty big memcpy) by Jonathan Gordon · 16 years ago
  99. 24b136f rework cuesheet support: by Jonathan Gordon · 16 years ago
  100. 3d4701a FS#10080 by Nils Wallménius · 16 years ago