Gitiles
Code Review Sign In
gerrit.rockbox.org / rockbox / 5565a28c7d9cf6217f5b85b3e078e74a3722175e / apps / buffering.c
  1. 5565a28 Remove some redundant #include's by Bertrik Sikken · 14 years ago
  2. 2494afc playback.c: don't assume cacheline size is 16 bytes by Rafaël Carré · 14 years ago
  3. 35e8b14 Rockbox as an application: Replace many occurences of #ifdef SIMULATOR with #if (CONFIG_PLATFORM & PLATFORM_HOSTED) (or equivalently). by Thomas Martitz · 14 years ago
  4. 9c13b6e fix: when move_handle() is successful, the return value corrects valid type. by Yoshihisa Uchida · 14 years ago
  5. 7d5e0d7 FS#11263 - Radio Art support! %C and %Cl tags work in the radio screen and Base Skin when the radio is running. by Jonathan Gordon · 14 years ago
  6. 6ef04a7 Eliminate %zd tag in printf format strings, replace them with %ld. The %z formatter kept generating type mismatch warnings. by Jeffrey Goode · 14 years ago
  7. 759cfec Hopefully the last warning by Frank Gevaerts · 14 years ago
  8. ed56682 Fix various size_t related warnings and errors by Frank Gevaerts · 14 years ago
  9. 84cd376 cast ssize_t to long by Rafaël Carré · 14 years ago
  10. 50a6ca3 Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes). by Thomas Martitz · 14 years ago
  11. a8d1690 Make storage alignement use cache alignement macros by Rafaël Carré · 15 years ago
  12. abb3dd4 Use a helpfer function to avoid ugly casting and correct some data types (no functional change). by Thomas Martitz · 15 years ago
  13. 4c78eca Hopefully fix yellow now, I don't understand why %ld works for ssize_t but %lu not for size_t (and still no warnings on my system). by Thomas Martitz · 15 years ago
  14. 81187d8 Fix yellow caused by signedness. by Thomas Martitz · 15 years ago
  15. df79ac2 Fix FS#11004 - Buffering crashes when skipping back from end of song. by Thomas Martitz · 15 years ago
  16. b11c819 Convert RINGBUF_* macros to inline functions, saving binsize and improving type safety. by Thomas Martitz · 15 years ago
  17. c4e051b Align addresses in the buffering code to STORAGE_ALIGN_MASK if the target has one. by Torne Wuff · 15 years ago
  18. f620103 buffering.c: cosmetics by Rafaël Carré · 15 years ago
  19. ecd9bcf Commit FS#10605 - stable playback on low memory swcodec targets by Matthias Schneider. Should allow stable playback on targets with less then 4MB of RAM and sofware decoding such as the Sandisk Clip, c200v2, m200v4 and probably others. Fixes several problems in buffering that occured when the files to be buffered weren't much smaller then the ring buffer size. Fixes a bug where move_handle would corrupt the audio buffer when trying to copy a handle that both wrapped around the highest address in the ring buffer and overlapped part of the source and desination ranges. Moves the decision in playback.c about when to update the current track handle from audio_check_new_track to after the metadata has been buffered. Corrects several other minor pieces of code. I've logged about 100 hours without a crash on various players with this patch but its possible it breaks some combination of players and features I haven't thought to test. by Michael Giacomelli · 15 years ago
  20. 59dd433 Removed unneeded includes by Jeffrey Goode · 15 years ago
  21. f3944cb buffering: leave a comment to explain what is broken in the code and link to FS#10605 by Rafaël Carré · 15 years ago
  22. e9c1018 Rework albumart buffering internally to allow for mutliple albumart sizes. by Thomas Martitz · 15 years ago
  23. 3d4701a FS#10080 by Nils Wallménius · 15 years ago
  24. 00d6cfd Fix yellow when building with HAVE_ALBUMART, without HAVE_JPEG/HAVE_BMP_SCALING. by Andrew Mahone · 15 years ago
  25. 216424a Fix the lock contention stall during cover art load, by adding a separate modify mutex for the buffer. Operations that modify contents of a buffer entry can still proceed, but ones that add or remove buffer entries, or move them by Andrew Mahone · 15 years ago
  26. 20f76d6 Make JPEG and BMP scaler optional with HAVE_JPEG and HAVE_BMP_SCALING, both defined for all targets that have HAVE_ALBUMART. Disable JPEG in PictureFlow and pluginlib album art search with 32KiB plugin buffer until PictureFlow by Andrew Mahone · 15 years ago
  27. 54e6eb3 Search for, and load, JPEG album art files. by Andrew Mahone · 15 years ago
  28. 66cf3a3 Clean up some #includes by Bertrik Sikken · 16 years ago
  29. fcbfef8 Show the watermark in the "Show buffering thread" screen (in bytes). by Thomas Martitz · 16 years ago
  30. 0055f13 This should fix the occasional data aborts mainly in conjunction with AlbumArt on PP targets. See FS#9827 for details. by Antonius Hellmann · 16 years ago
  31. 6427d12 Calculate watermark from bitrate and harddisk spinup time. by Björn Stenberg · 16 years ago
  32. 9058620 Make scaler output truly pluggable, add an 8-bit greyscale output to by Andrew Mahone · 16 years ago
  33. 8cfbd36 Use cookies for thread identification instead of pointers directly which gives a buffer against wrongly identifying a thread when the slot is recycled (which has been nagging me for awhile). A slot gets 255 uses before it repeats. Everything gets incompatible so a full update is required. by Michael Sevakis · 16 years ago
  34. 781421a resize-on-load for bitmap files on 2bpp and color targets by Andrew Mahone · 16 years ago
  35. 3625be4 Fix FS#9319 and its (probably) duplicate, FS#9576. They both describe the boost remaining active after a change of the dynamic playlist, an issue added in r17109. by Nicolas Pennequin · 16 years ago
  36. 2f8a008 Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*. by Frank Gevaerts · 16 years ago
  37. 71898e5 Accept FS#9480 - centralise and organise the events in the apps/ layer. by Jonathan Gordon · 16 years ago
  38. f397c25 Fix a possible deadlock if the album art loading fails by Jonathan Gordon · 16 years ago
  39. cf36957 Add handle values to the buffering LOGFQUEUE messages for easier debugging. by Nicolas Pennequin · 16 years ago
  40. 929d5e9 Fix FS#9137 and FS#8194 (the end of a track is cut off after rebuffering): the cause was a confusion between regular subtraction and subtraction in a ring-buffer. by Nicolas Pennequin · 16 years ago
  41. 7c84ede Hopefully fix FS #9153, as well as another bug (in fill_buffer) that could cause problems when rebuffering. by Magnus Holmgren · 16 years ago
  42. a2191b9 Fix FS#8964 (CPU remains boosted after buffering). 'filling' needs to be set to false when there's nothing left to buffer. by Nicolas Pennequin · 16 years ago
  43. 2acc0ac Updated our source code header to explicitly mention that we are GPL v2 or by Daniel Stenberg · 16 years ago
  44. f7e0e6b Lock the linked list mutex when accessing the memory handles. This should fix the invalid values appearing for short times in the buffering debug screen. by Nicolas Pennequin · 16 years ago
  45. e02d031 Remove unused #define. by Steve Bavin · 16 years ago
  46. c97e503 Cleaned up playblack.h header file and usage of it. by Bertrik Sikken · 16 years ago
  47. de026dc Fix FS#8902 (NSF files get skipped). The cause was too strict metadata checking (the NSF metadata parser doesn't fill the 'length' field). Hopefully there won't be any problems with that anymore. by Nicolas Pennequin · 16 years ago
  48. 4e2de44 A rather big change to how tracks are loaded: there are now two parts to the process and metadata loading is done by the buffering thread (except for the first unbuffered track). The audio thread now calls audio_load_track, and once the metadata is loaded, the buffering thread sends an event which will make the audio thread call audio_finish_load_track. This one then takes care of the rest of the loading. by Nicolas Pennequin · 17 years ago
  49. 2bf4178 Make mpegplayer sleep the disk after buffering to save battery. * Add a simulator stub for ata_sleep(), and un-ifdef most calls to it. by Jens Arnold · 17 years ago
  50. 33f522d Migrate the buffering code to the new events system. by Nicolas Pennequin · 17 years ago
  51. 8a6fd3f Just change PRIORITY_BUFFERING to 15. Seems a teeny tiny bit helpful to mpegplayer as well. by Michael Sevakis · 17 years ago
  52. 9120c85 Change the default buffer filechunk back to 32KB and bump the buffering thread priority up by one. by Michael Sevakis · 17 years ago
  53. 12b6c84 Fix sim warnings. by Nicolas Pennequin · 17 years ago
  54. 732df38 Boost the audio thread while it's filling the buffer. In the audio and the buffering threads, only cancel cpu boost when not filling. by Nicolas Pennequin · 17 years ago
  55. 4fd2774 Correct some windows line endings back to unix. by Nicolas Pennequin · 17 years ago
  56. 135cc75 Revert my earlier const madness, we'll keep the parameter lists simple. by Steve Bavin · 17 years ago
  57. c9df8fd The const police raid playback.c, should be no change to behaviour. by Steve Bavin · 17 years ago
  58. 73f9863 More consts that require no functional change. by Steve Bavin · 17 years ago
  59. 27cf677 Add a complete priority inheritance implementation to the scheduler (all mutex ownership and queue_send calls are inheritable). Priorities are differential so that dispatch depends on the runnable range of priorities. Codec priority can therefore be raised in small steps (pcmbuf updated to enable). Simplify the kernel functions to ease implementation and use the same kernel.c for both sim and target (I'm tired of maintaining two ;_). 1) Not sure if a minor audio break at first buffering issue will exist on large-sector disks (the main mutex speed issue was genuinely resolved earlier). At this point it's best dealt with at the buffering level. It seems a larger filechunk could be used again. 2) Perhaps 64-bit sims will have some minor issues (finicky) but a backroll of the code of concern there is a 5-minute job. All kernel objects become incompatible so a full rebuild and update is needed. by Michael Sevakis · 17 years ago
  60. 483c402 Notify the buffering thread when a handle is added, so it can go into filling mode. This is some sort of a replacement for the ATA idle callback. It will interrupt an ongoing buffering process (buffer_handle), but not for long enough to be a problem. by Nicolas Pennequin · 17 years ago
  61. 659fe5a Fix FS#6215 (player crashes after trying to resume deleted music file). As mentioned in the lastest comment, the problem was in trying to resume at an offset larger than the size of the file following the one that was deleted. This revealed a crash in the buffering code, which gets a fix, but we also need to intervene earlier in the track loading so that the track that gets played will be from its start. by Nicolas Pennequin · 17 years ago
  62. ecec940 Check that the pointer isn't NULL before dereferencing it, just to be safe and to allow using bufgetdata to know how much data is available. Also remove a few trailing spaces. by Nicolas Pennequin · 17 years ago
  63. e959c5a Possibly save a few bytes when stripping the tags of the last allocated handle by Brandon Low · 17 years ago
  64. 3386dd7 Fix FS8069, because Nico_P made it easy by Brandon Low · 17 years ago
  65. 774fd19 Checking for total free buffer space isn't correct. What we need to check is the space available for the particular handle we want to rebuffer. by Nicolas Pennequin · 17 years ago
  66. e24454f Buffering callbacks rework. There is now one callback for all the events that can occur. Callbacks are now registred only once instead of being removed after having been called. by Nicolas Pennequin · 17 years ago
  67. 398d9fd Hopefully the last word on getting rid of yield_codecs loops (cut read chunk to 16kB). Sansa ata driver also didn't yield enough so buffering would starve other threads. Bump priority of audio thread to keep UI more responsive. by Michael Sevakis · 17 years ago
  68. fadbf0a Make threads responsible for explicit cancellation of their own boosted status. Sleeping and timeouts will no longer cancel it. by Michael Sevakis · 17 years ago
  69. 5192370 Make the sim sleep between each file chunk, so that its buffering behaves more like that of a real target. by Nicolas Pennequin · 17 years ago
  70. 87e5b11 The error checking for bitmap handling in bufopen was serioulsy broken, as loading a huge bitmap showed. Fix it and reorganise the code slightly. by Nicolas Pennequin · 17 years ago
  71. 5e0e239 Really fix red this time. by Nicolas Pennequin · 17 years ago
  72. a384fb6 Fix red on the iFP. by Nicolas Pennequin · 17 years ago
  73. 9d4bed7 Album art support. Based on FS#3045, but heavily modified to adapt to MoB and for cleanness. by Nicolas Pennequin · 17 years ago
  74. dc0f497 No functional change by Brandon Low · 17 years ago
  75. b50473f Fix a bug introduced by r15533 where end-of-file wouldn't be detected correctly. by Nicolas Pennequin · 17 years ago
  76. ca4771b Thanks to the changes in prep_bufdata, bufgetdata can be simplified a bit. by Nicolas Pennequin · 17 years ago
  77. 551db40 Clean up a (nearly impossible) null check. Add a comment. by Brandon Low · 17 years ago
  78. 1db4243 Change in function should be nearly zero, but change to proper naming and define use and allow a more liberal limit on bufgetdata to only ensure safety of wrapping, not the strict filechunk limit that I tried to impose earlier by Brandon Low · 17 years ago
  79. 6e8ee40 Fix some bad where a handle is held across a sleep. We should probably audit this in other places as well. by Brandon Low · 17 years ago
  80. f56cb7e Fix the bug where MPC files would be skipped by disabling the check of the requested size against the default filechunk size in prep_bufdata when the caller is bufread. by Nicolas Pennequin · 17 years ago
  81. 71b4099 Fix a flaw in prep_bufdata() that would lead to all kinds of problems with codecs that used bufread (MPC is one). by Nicolas Pennequin · 17 years ago
  82. 3eed6fc Fix thinko in last patch, shouldn't effect current buffering clients. by Brandon Low · 17 years ago
  83. 9821cce Pull the size range checking and disk request into a separate function that both bufread and bufgetdata can use. Do better range checking to ensure that we don't get 'stuck' in the calls and warn with a logf if requests are made for which we cannot guarantee satisfaction. by Brandon Low · 17 years ago
  84. 86b7c2b This was (probably) committed by accident, remove it. by Nicolas Pennequin · 17 years ago
  85. 7ca056d Don't yield twice in a row by Brandon Low · 17 years ago
  86. eac794d Types other than packet audio still need to yield while buffering. by Nicolas Pennequin · 17 years ago
  87. 0c7b26d Readd yield_codec, making it check for useful data through buffer_is_low. Fixes the PCM buffer underruns. by Nicolas Pennequin · 17 years ago
  88. 287f14b This was a bad change on my part earlier. Do not immediately start buffering codecs when they are bufopened by Brandon Low · 17 years ago
  89. 6631e36 Fix some logf warnings. by Nicolas Pennequin · 17 years ago
  90. 86830b6 Create two separate ways for a handle buffer request to be sent. One is when the buffer has gotten low, in this case, we want to start a buffer fill. The other is when the buffer itself requests a buffer as part of a running fill. Obviously this is not a new fill start by Brandon Low · 17 years ago
  91. 76f9bfa When seeking foward off of the buffer, if it is a short seek don't rebuffer the whole track, just read enough to satisfy by Brandon Low · 17 years ago
  92. 3379440 Remove conf_filechunk, it should never have been a setting and its implementation doesn't do what it claims any way by Brandon Low · 17 years ago
  93. 1df1e7b Remove unused conf_preseek from buffering.c and all of its accountraments. This is _not_ a setting. This is a guessing tool used by either playback or buffering to serve its clients better. Use the REBUFFER_GUESS size in resume to help obviate pondlife's bug. This will also need to be used when FS8092 gets fixed correctly with a complete rebuffer for backward movements. It may also belong in buffering not playback, haven't decided for sure by Brandon Low · 17 years ago
  94. 560515f Minor improvement in responsiveness to buffer_handle calls by Brandon Low · 17 years ago
  95. 555a764 logging improvements by Brandon Low · 17 years ago
  96. 47eb569 SHould fix FS#8074, is more better regardless though by Brandon Low · 17 years ago
  97. d02b5c7 Don't keep useless id3v2 or other leading tag data on the buffer, it could be large by Brandon Low · 17 years ago
  98. 31c1164 make handle_id of zero valid, stop using memsets to clear tracks, should be no functional changes by Brandon Low · 17 years ago
  99. 2ecb323 More residuals from 8077, sanitize chunk and watermark settings by Brandon Low · 17 years ago
  100. ebc981b More residuals from 8077 that should make buffering start up more smoothly and complete more completely by Brandon Low · 17 years ago