Gitiles
Code Review Sign In
gerrit.rockbox.org / rockbox / c1810b31f170e887668652ff4e3d76c392a5fb70 / apps / playback.c
  1. b591bb3 FS#5691 Fix for crash if stop pressed during voice output. by Miika Pekkarinen · 18 years ago
  2. 8e0b02a Prevent buffer filling trying to start over and over causing playback by Miika Pekkarinen · 18 years ago
  3. bb5330c Don't yield_codecs() within codec thread. by Miika Pekkarinen · 18 years ago
  4. ab279dd Stop playback before updating runtime stats. And yield codecs while by Miika Pekkarinen · 18 years ago
  5. 513cafe Checked the rebuffering code. Might fix buffers desyncing and a system crash. by Miika Pekkarinen · 18 years ago
  6. 4ccacd4 Completely remove all track entries at audio_rebuffer(). by Miika Pekkarinen · 18 years ago
  7. 3b2f049 Another oops. by Miika Pekkarinen · 18 years ago
  8. 2fa6825 Oops, committed some extra stuff not necessary. by Miika Pekkarinen · 18 years ago
  9. d43bff9 Define MAX_TRACK_MAX and use it to keep the ring track structure by Miika Pekkarinen · 18 years ago
  10. 6128ff3 Fixed one of the many pending bugs in the playback engine and restored by Miika Pekkarinen · 18 years ago
  11. 0d8c50d Add resume support for AC3 files. by Magnus Holmgren · 18 years ago
  12. 50f7e4e Additional fix for seeking beyond the current buffered data by Mark Arigo · 18 years ago
  13. 752faa4 Patch #5157 by Rainer Sinsch - SID codec by Dave Chapman · 18 years ago
  14. 45dfe2a Initial runtimedb support for tagcache. Only for developers, by Miika Pekkarinen · 18 years ago
  15. b1a272e Patch by Mark Arigo to close bug report #5305 - fixes crashes when attempting to seek beyond the currently buffered data. by Dave Chapman · 18 years ago
  16. 75117cc Wait for voice to complete before stopping playback. Fixes hang when stopping from filetree while voice is playing. by Hardeep Sidhu · 18 years ago
  17. a02fd1a Only swap_codec() in voice thread when something is playing. Fixes B#5486. by Hardeep Sidhu · 18 years ago
  18. 630e958 Fix resume for MP1. Thanks go to Dave Chapman for the hint. by Jens Arnold · 18 years ago
  19. 1e0b1d5 Stop playback if playlist_next() returns -1 (e.g. if auto directory change fails) by Hardeep Sidhu · 19 years ago
  20. f95dd56 Fix bug 5341: Resume in Wav and Flac doesn't start from the position where it was left off. Mark Arigo helped with the Flac fix. by Magnus Holmgren · 19 years ago
  21. 5483da6 Previous automatic skip fix had a problem if audio_fill_file_buffer() was called after setting playlist_end but before audio_check_new_track(). To fix this, playlist_end is now reset in audio_check_new_track(). by Hardeep Sidhu · 19 years ago
  22. db1cda8 Replace "#if (ROCKBOX_HAS_LOGF == 1)" with "#ifdef ROCKBOX_HAS_LOGF" - this is consistent with the rest of Rockbox and Mark Arigo reported that it caused an error in his gcc when trying to compile a logf-enabled sim by Dave Chapman · 19 years ago
  23. a892880 Reset playlist_end when automatically skipping. Fixes B#5319. by Hardeep Sidhu · 19 years ago
  24. c9a11cd Reset id3 info in all cases where we need to rebuffer tracks by Hardeep Sidhu · 19 years ago
  25. c8e280c Reset id3 info when skipping directories. Fixes B#5323. by Hardeep Sidhu · 19 years ago
  26. 6a267a8 Don't initiate track change if at end of playlist by Hardeep Sidhu · 19 years ago
  27. 7033bae Only reset resume settings when we're really at the end of the playlist by Hardeep Sidhu · 19 years ago
  28. 982d995 Stop playing current track before starting a new playlist with an offset (eg. bookmarks). by Hardeep Sidhu · 19 years ago
  29. b8d1a55 Properly set audio_is_initialized flag for swcodec devices ad use it when initializing crossfade. This should fix the problems with resuming playback at startup. by Hardeep Sidhu · 19 years ago
  30. e187e01 Fix one seeking bug: when seeking back to before a resume point, audio from another track could be played. by Magnus Holmgren · 19 years ago
  31. 4564f5c Don't magically skip tracks without user interraction by Brandon Low · 19 years ago
  32. 69cf4f5 This seems to fix a few bugs in that by Brandon Low · 19 years ago
  33. da1cddf This seems to make selecting a new track from the file browser work very close to right. by Brandon Low · 19 years ago
  34. 522ec27 Switch inserts back from do while to while loops, because mpc likes to insert zero byte chunks at the end of files. by Brandon Low · 19 years ago
  35. 3ac7bd7 Fix the most likely cause of ipod nano startup race, and also seems to fix crossfade buffer reinitialization during playback for me by Brandon Low · 19 years ago
  36. e0f7ecb Make track info update in a smarter way by Brandon Low · 19 years ago
  37. d461a3e Fix some todos, and prevent the position from jumping around badly on seek by Brandon Low · 19 years ago
  38. 6a6c322 Improve stop behavior by Brandon Low · 19 years ago
  39. 5cdee94 Fix a warning, and prepare for handling end-of-track seeking by Brandon Low · 19 years ago
  40. 2e8b933 Should fix some track ending early problems by Brandon Low · 19 years ago
  41. 8ecb858 Make some adjustments to when the WPS will be updated, giving faster next track and cleaner track change updates by Brandon Low · 19 years ago
  42. 83ce568 Remove an unneeded define, add a todo by Brandon Low · 19 years ago
  43. c71ad7e Fix warning by Brandon Low · 19 years ago
  44. f3bc1ef First commit of reworking voice to be mroe stable on swcodec by Brandon Low · 19 years ago
  45. f635f4a Set playing to true immediately when audio_play() is called. Fixes a bug when selecting tracks from playlist viewer. by Hardeep Sidhu · 19 years ago
  46. 4b36096 Have the codec thread stop the pcm if we need to spin up the disk by Brandon Low · 19 years ago
  47. 56d6f3e Fix playback if the user does a very fast seek->skip press by Brandon Low · 19 years ago
  48. 2c9b171 Fix end of playlist handling. I think. by Brandon Low · 19 years ago
  49. 1344ccd Revert previous, it is broken by Brandon Low · 19 years ago
  50. 426dc21 Make seeking synchronous. It's better this way by Brandon Low · 19 years ago
  51. 2b18727 Fix dir skipping with new playback arch. Enable dir skipping on ipod with a couple of difficult combos (select|right/left) or short-long left / short-long right. The latter causes stuck in pause sometimes. by Brandon Low · 19 years ago
  52. ed44e19 Should fix a bug with track skipping backwards following track skip forward, play, seek backward by Brandon Low · 19 years ago
  53. 7df187f Save empty resume information if the playlist has ended by Brandon Low · 19 years ago
  54. 095ae80 Reduce code size when logf is off. Add a todo. Undo a previous fix that broke crossfade on manual track changes by Brandon Low · 19 years ago
  55. 98097d2 Misc. minor fixes: Guarantee aligned buffer. Enable load-codec-from-disk if a new track requires a different codec than the playing track, but does not already have it on the buffer. Stop playback immediately on a manual track skip. Handle seeking a distance greater than the size of the audio buffer. Enforce the 'no malloc for voice codec'. by Brandon Low · 19 years ago
  56. bf397b5 Remove an unneeded WPS update signal. Make the codec thread more polite about requesting buffering. Prevent more Codec failure pops when the codec was _asked_ to stop. by Brandon Low · 19 years ago
  57. ebadcc6 Put new_track on the codec_api, and use it instead of the reload_codec variable in most places. Should help with problems people have had with GUI vs. playback sync. by Brandon Low · 19 years ago
  58. 363dbc4 This might fix the buffering problem. Didn't happen to me the way I usually reproduce it just now by Brandon Low · 19 years ago
  59. 530cad3 Still not bright by Brandon Low · 19 years ago
  60. de25006 I am dumb by Brandon Low · 19 years ago
  61. 7c986a9 Work around the bug with buffer wrapping. Serious performance penalty, and a lot of buffering is discarded to achieve this, but it doesn't crash while I find the real cause by Brandon Low · 19 years ago
  62. 348d9ec Fix some unlikely buffer problems. Doesn't fix any reported bugs, but fixes some possible ones. by Brandon Low · 19 years ago
  63. 86c7e1a Fix some stop/pause/boost stuff by Brandon Low · 19 years ago
  64. fb966b3 Fix a lack of return on error for check_new_track (rare condition) by Brandon Low · 19 years ago
  65. 0291a6e Fix the queue implementation by Brandon Low · 19 years ago
  66. fd08424 Change to using a queue to synchronize between threads instead of abusing a mutex by Brandon Low · 19 years ago
  67. fbe74d1 Fix one cause of buffer-offness, but I'm pretty sure this is not the cause of problems that people are having as the debug code I put in detects and corrects it. Make taginfo instead of stupid filename appear on manual track skip, off buffer (stupid bug). by Brandon Low · 19 years ago
  68. 2f4edab Tweak id3v1 tag stripping, better code, same functionality. Ensure correct buf_idx on track when rebuffer&seek. by Brandon Low · 19 years ago
  69. 2f11d60 Change when the new_track variable is reset to fix the track display during skipping by Brandon Low · 19 years ago
  70. 1d41f77 Boost during the track transition, trust me, it makes sense. Better logging of buffer-not-synched issues. Revert a previous change to make a function take a parameter intead of using cur_ti. Add some todos. by Brandon Low · 19 years ago
  71. 017914a Adjust filesize if id3v1 is stripped by Brandon Low · 19 years ago
  72. 0744e76 Ensure that the buffer doesn't get out of sync on rebuffer track changes. Remove the concept of pcmuf_boost_mode as it doesn't seem necessary, and adds an unnecessary way for the CPU to stay boosted. by Brandon Low · 19 years ago
  73. 483c947 Add a logf, remove an unused parameter, and an unused member of the track_info struct, ensure that we unboos on stop even if buffering, make a function take a parameter instead of using a global by Brandon Low · 19 years ago
  74. c95044a Track skipping rework more. This seems to handle rapid skipping very gracefully without compromising buffer safety. There may still be a potentially broken code path if the user does a very rapid skip, stop sequence, and I will be sure to investigate this. Due to Slasheri's concern, reimplement rapid GUI update for track skipping in a safe way. by Brandon Low · 19 years ago
  75. b1fa534 Simplify audio startup, and remove some unnecessary code by Brandon Low · 19 years ago
  76. 44d9576 Track changes should zero the seek_time to prevent undesired seeking in the new track by Brandon Low · 19 years ago
  77. 54af304 use the cur_ti pointer, as it's always synched up with track_ridx any way by Brandon Low · 19 years ago
  78. 3769501 Get the GUI and audio in sync for track changes by Brandon Low · 19 years ago
  79. 10c3a34 Fix major rebuffer stupidity, remove a redundant call, and a wrong comment. by Brandon Low · 19 years ago
  80. af09d22 Add and improve logfing, fix a possible cause of problems due to abuse of read_next_metadata by Brandon Low · 19 years ago
  81. d6b370b Fix logf build, fix double reporting buffer events. by Brandon Low · 19 years ago
  82. 87484fc Almost entirely formatting changes, but also add one logf, and fix one nearly impossible to hit (I doubt it's been hit in the history of rockbox) bug by Brandon Low · 19 years ago
  83. 8529414 Clarify a comment by Brandon Low · 19 years ago
  84. 8966c01 Clear tracks in more appropriate ways/places by Brandon Low · 19 years ago
  85. 01219fa Handle rebuffer-and-seek and track skip buffer events smarter. Fill the buffer all the way around on a 'normal' rebuffer. Rename and invert a strangely named variable for simpler logic. by Brandon Low · 19 years ago
  86. a476718 Fix yellow by Brandon Low · 19 years ago
  87. 73365c8 Fix a (very unlikely) bug in buffering by Brandon Low · 19 years ago
  88. b660745 Fix some signedness and exit condition stuff. Not sure if this addresses live bugs, but it was wrong nonetheless by Brandon Low · 19 years ago
  89. 6bd1f14 Try to recover from a codec failure by restarting playback by Brandon Low · 19 years ago
  90. afb64a4 Whoops, remove a done TODO by Brandon Low · 19 years ago
  91. a9debda Fix some comments by Brandon Low · 19 years ago
  92. 3b76544 Ensure that codecs are cleared from the buffer if they will not be needed by the track about to play and some minor changes for correctness with no functional difference by Brandon Low · 19 years ago
  93. 62ccbbb Rework track skipping. Full playback stop is no longer involved in track skipping. Further simplification of the play related functions can be achieved with this in place, but that's for later. Known skip related bug, high pitched noise sometimes, otherwise stuff is better by Brandon Low · 19 years ago
  94. 2caad6f Get the next track's metadata in a more timely manner by Brandon Low · 19 years ago
  95. 25e367c Formatting, and logf changes by Brandon Low · 19 years ago
  96. 4f3bb2d Fix another nasty rebuffering bug, and ensure that buffer and unbuffer events are triggered correctly. Also remove another unused varialbe track_info->filepos by Brandon Low · 19 years ago
  97. 72232bd Fix bad rebuffering bug, and kill the track_count variable by Brandon Low · 19 years ago
  98. 3e3c21b Fix the condition on an error splash by Brandon Low · 19 years ago
  99. 502fbd7 Correct seeking behavior (whoops), might fix the coldfire deadlocks. Reintroduce the foreshortened initial buffer fill, this should maybe be optional by Brandon Low · 19 years ago
  100. 0be0b43 Fix seeking not resuming playback, many thanks to Ralf Herz for being an excellent debugger by Brandon Low · 19 years ago