Gitiles
Code Review Sign In
gerrit.rockbox.org / rockbox / ef9ee8935f3ec95a636272cf6c19f55573f5ee6d / apps / playlist.c
  1. 929ea73 playlist.c suppress playlist access error on usb plug by William Wilgus · 6 years ago
  2. 3f110da Fix tree.c->tree_get_entry_at() buffer overflow by William Wilgus · 6 years ago
  3. 2fb6b2b Fix truncation warning playlist.c, tree.c by William Wilgus · 6 years ago
  4. ff62528 Make playlist CRC the correct path when saving resume info by Michael Sevakis · 7 years ago
  5. 7373cf5 Restore dircache hookup in the database ramcache. by Michael Sevakis · 8 years ago
  6. 16a9f84 Reenable database ramcache and playlist dircache by Michael Sevakis · 8 years ago
  7. 5c6ccb4 Fix track formatting problems in playlist.c by Michael Sevakis · 8 years ago
  8. f8d9e9c m3u playlist parser: Check size limit before using buffer by Thomas Jarosch · 10 years ago
  9. 4c6939f Correct some file permissions. by Szymon Dziok · 10 years ago
  10. 7d1a47c Rewrite filesystem code (WIP) by Michael Sevakis · 11 years ago
  11. 35b4ba8 root_menu: Remove previous_music_is_wps() and change previous_music via event callback. by Thomas Martitz · 10 years ago
  12. bebf71a playlist: Get rid of plugin buffer use in playlist_save(). by Thomas Martitz · 11 years ago
  13. 470989b events: Rework event subsystem (add_event, send_event) to be more versatile. by Thomas Martitz · 11 years ago
  14. 31b7122 Implement time-based resume and playback start. by Michael Sevakis · 11 years ago
  15. 706e6b7 Move VOL_NAMES definition to mv.h by Thomas Martitz · 11 years ago
  16. 22e802e playback,talk: Share audiobuffer via core_alloc_maximum(). by Thomas Martitz · 11 years ago
  17. 212e780 Use crc32 of filename to resume tracks by Richard Quirk · 12 years ago
  18. d245997 Fix warning on previous commit. by Michael Giacomelli · 12 years ago
  19. b30edcd Make playlist.c aware of external storage when determining paths by Michael Giacomelli · 12 years ago
  20. beb61a9 Not quite a fix for FS#12693 yet, but at least invalidate the playlist file descriptors after closing and removing by Bertrik Sikken · 12 years ago
  21. be10817 Option to constrain get_next_dir() to directories below global_settings.start_directory. by Nick Peskett · 13 years ago
  22. 9c72039 Fix FS#12499 - Directory playback fails after saving playlist by Boris Gjenero · 13 years ago
  23. bda8a96 Add conditionals for functions only needed on SWCODEC targets. by Boris Gjenero · 13 years ago
  24. 1645c14 Simulate usb plugging on the sim better using sim_tasks. by Thomas Martitz · 13 years ago
  25. 0942e2a Changed the FOR_NB_SCREENS macro to always be a for loop that declares its own loop variable. This removes the need to declare this variable in the outer scope. by Björn Stenberg · 13 years ago
  26. baa070c GSoC/Buflib: Enable compaction in buflib. by Thomas Martitz · 13 years ago
  27. d0b72e2 GSoC/Buflib: Add buflib memory alocator to the core. by Thomas Martitz · 13 years ago
  28. 12ac381 Fix file descriptor leak on error by Thomas Jarosch · 13 years ago
  29. d1322b7 GSoC/Buflib: Replace all direct accesses to audiobuf with buffer API functions. by Thomas Martitz · 13 years ago
  30. 9809697 Cleanup tree.c cache handling a bit. by Thomas Martitz · 13 years ago
  31. d1fd4f0 Fix FS#8656 - Error saving non-current playlist file by Jonathan Gordon · 13 years ago
  32. 5eb2f60 Revert r30030 "Remove unused code path from playlist_create_ex()." by Thomas Martitz · 13 years ago
  33. 00dfcb8 Fix FS#12181 - Playlist re-shuffle does not work (r30122) by Thomas Martitz · 13 years ago
  34. 2bc133d Try to handle dircache rebuild event properly. Playlist should now by Miika Pekkarinen · 13 years ago
  35. af7aaae Dircache: Don't expose struct dircache_entry and pointers into the cache, use IDs instead. by Thomas Martitz · 13 years ago
  36. e063725 Dircache: Return the size of the result string in dircache_copy_path() so that callers don't need to call strlen on it. by Thomas Martitz · 13 years ago
  37. 1a86aab Remove unused code path from playlist_create_ex(). by Thomas Martitz · 13 years ago
  38. c537d59 Commit FS#12069 - Playback rework - first stages. Gives as thorough as possible a treatment of codec management, track change and metadata logic as possible while maintaining fairly narrow focus and not rewriting everything all at once. Please see the rockbox-dev mail archive on 2011-04-25 (Playback engine rework) for a more thorough manifest of what was addressed. Plugins and codecs become incompatible. by Michael Sevakis · 13 years ago
  39. d5849e0 Playlists forget to set playlist.started when creating new playlist on SWCODEC and which leads to flush-and-rebuffer messages never being sent again until playback is restarted. by Michael Sevakis · 14 years ago
  40. 39d9d8b Fix red and yellow. Move resume_index from mp3entry to playlist_info struct. Bump codec api. by Andree Buschmann · 14 years ago
  41. 4df825b Fix regressions of r29682. Update playlist index resume position when playlist changes (e.g. shuffling, inserting, removing, ...). by Andree Buschmann · 14 years ago
  42. 3184cbe Fix FS#12043. Next track was resumed when pausing and shutting down the player in the last seconds of a track. by Andree Buschmann · 14 years ago
  43. 3926c30 Make sure we don't read past the end of a C-string in format_track_path. Second part of FS #11947 by Thomas Jarosch · 14 years ago
  44. 15a5f9c Don't underflow the buffer in format_track_path() if it consists of whitespaces by Thomas Jarosch · 14 years ago
  45. 84fccff Fix off-by-one buffer read access in format_track_path(). Part of #11947 by Thomas Jarosch · 14 years ago
  46. b15aa47 All kernel objects in code shared amongs targets (core, plugins, codecs) should be declared SHAREDBSS_ATTR as any core could potentially touch them even though they seem only to involve threads on one core. The exception is target code for particular CPUs where proper allocation is fixed. playlist.c was a little odd too-- use one mutex for the current playlist and a separate one for created playlists (still pondering the necessity of more than one). by Michael Sevakis · 14 years ago
  47. 2c24160 Get rid of get_user_file_path and do the path handling in wrappers for open() and friends. by Thomas Martitz · 14 years ago
  48. 47f670d FS#11725: fix duplicationg slash indicating root in filename. by Teruaki Kawashima · 14 years ago
  49. 1dfebdd playlist_shuffle(): remove unused variable by Rafaël Carré · 14 years ago
  50. 113764d Fix FS#11175. playlist_peek() wasn't thread safe (due to a static filename buffer), so frequent calls from the main thread would cause the audio thread to buffer the wrong track. by Magnus Holmgren · 14 years ago
  51. 9c0b247 Rockbox as an application: add get_user_file_path(). by Thomas Martitz · 14 years ago
  52. 35e8b14 Rockbox as an application: Replace many occurences of #ifdef SIMULATOR with #if (CONFIG_PLATFORM & PLATFORM_HOSTED) (or equivalently). by Thomas Martitz · 14 years ago
  53. b08222c Minor const police raid. by Steve Bavin · 14 years ago
  54. 50a6ca3 Move c/h files implementing/defining standard library stuff into a new libc directory, also standard'ify some parts of the code base (almost entirely #include fixes). by Thomas Martitz · 14 years ago
  55. 0a1d7c2 Make open() posix compliant api-wise. A few calls (those with O_CREAT) need the additional optional mode parameter so add it. Impact for the core is almost zero, as open() is a wrapper macro for the real open function which doesn't take the variable parameter. by Thomas Martitz · 14 years ago
  56. a70d602 Aceppt FS#10945 by Tomasz Kowalczyk - Fix playlists not returning to the origional order after shuffle/unshuffle by Jonathan Gordon · 15 years ago
  57. d0729ab fix FS#10288 by Tomasz Kowalczyk. Fixes issues where resuming a "insert shuffled" playlist doesnt recreate the same playlist that was stopped.. (I'm tipsy still... read the task for more info :p ) by Jonathan Gordon · 15 years ago
  58. 6643a3b Fix FS#9660 - make warn on playlist erase work correctly when creating a new playlist from the database (a bit of a hack, but not bad enough to outright reject) by Jonathan Gordon · 15 years ago
  59. ee15637 FS#10834 by Alex Bennee, fixing off-by-one bug in code calling format_track_path by Nils Wallménius · 15 years ago
  60. 494fd96 Committing FS#10717 by Tomasz Kowalyczyk: add PLAYLIST_INSERT_LAST_SHUFFLED (appends the inserted folder into shuffled order to end of playlist) by Dave Hooper · 15 years ago
  61. 774bacc Correct wrong usage of event callbacks all over the place. It's not supposed to return anything, and should take a data parameter. by Thomas Martitz · 15 years ago
  62. 3d4701a FS#10080 by Nils Wallménius · 15 years ago
  63. 008f611 Fix bug in playlist_move where the track would end up one place too early / too late if the move wrapped from one end of the playlist indices to the other end by Dave Hooper · 15 years ago
  64. f0aa8ba playlist start can only have 1 return value (0), so make it return nothing. by Thomas Martitz · 15 years ago
  65. e84520c Revert FS#9531 / r19723 - It did not fix the problem, and it caused the index parameter of shuffle and unshuffle .playlist_control commands to be ignored. When those parameters were non-zero, this caused some tracks from the end of the original playlist to instead appear at the beginning of the resumed playlist. by Boris Gjenero · 16 years ago
  66. 4ae7415 Fix insert/queue next, last and replace to update the last insert position too, by Thomas Martitz · 16 years ago
  67. 87d1744 Fix playlist "Insert" a bit. by Thomas Martitz · 16 years ago
  68. 66cf3a3 Clean up some #includes by Bertrik Sikken · 16 years ago
  69. f5ab7c0 Commit patch by JdGordon to fix FS#9531 (which applied to all targets) - correctly resume shuffled playlists. by Marianne Arnold · 16 years ago
  70. 2f8a008 Apply FS#9500. This adds a storage_*() abstraction to replace ata_*(). To do that, it also introduces sd_*, nand_*, and mmc_*. by Frank Gevaerts · 16 years ago
  71. 2ca30a0 Minor clean up, move common define to a header file and use TIME_AFTER macro by Nils Wallménius · 16 years ago
  72. a0c91ae Make the array static const char, and use it for direct lookup, saving binsize this way. by Jens Arnold · 16 years ago
  73. 48b52ae Fix FS#8949 - Alphabetical directory listing reversed after "Error Accessing Directory", patch by pondlife, some long line police by me, also kill a few error splashes in functions that could be called by threads other than UI by Nils Wallménius · 16 years ago
  74. 4657301 add HAVE_DISK_STORAGE, and use that instead of HAVE_FLASH_STORAGE when checking for an actual disk (i.e. related to spindown, skipping,...) by Frank Gevaerts · 16 years ago
  75. 93a8768 Clean up use of snprintf where strncpy if suited, avoid useless copying of constant strings for wps token evaluator, minor const police too. by Nils Wallménius · 16 years ago
  76. 95f516e more slight playlist resume cleanuping... dont bother saving the playlist first index value. its reset to 0 before playlistcontrol is loaded anyway, and then reset to 0 after its finished so its completly useless in global_status. by Jonathan Gordon · 16 years ago
  77. 40d713c FS#9408 - dont bother saving the random seed in global status. I'm 99.9% sure this code was being ignored anyway. by Jonathan Gordon · 16 years ago
  78. 01729e7 FS#9281 Rename of splash functions. by Nils Wallménius · 16 years ago
  79. faf32a2 r10544 changed the playlist reloading so you couldnt actually abort the process. This fixes it... by Jonathan Gordon · 16 years ago
  80. e299216 Fix problem with utf8 playlists containing a BOM breaking all entries but the first -- the index calculation needs to take the BOM size into account. by Dominik Riebeling · 16 years ago
  81. 02103a2 Unify opening of utf-8 files (FS#6203). This also adds ignoring the BOM in several places it has been missing (as FS#6071). by Dominik Riebeling · 16 years ago
  82. fa98298 Only voice track insertion splash if voice menus enabled - fix for FS#9223 by Steve Bavin · 16 years ago
  83. f48cf62 fix the random folder behaviour by not letting it start folders which dont have music in them (but were being started before because it has subdirs with music) by Jonathan Gordon · 16 years ago
  84. 8f3175b fix FS#9119 (crash if random folder list has no entries) by Jonathan Gordon · 16 years ago
  85. 2acc0ac Updated our source code header to explicitly mention that we are GPL v2 or by Daniel Stenberg · 16 years ago
  86. 82ed56b When saving a .m3u8 playlist, include a byte order mark (BOM), as some applications require it. by Magnus Holmgren · 16 years ago
  87. bdbdb97 FS#9051 - remove LCD margins... use viewports if you need them... by Jonathan Gordon · 16 years ago
  88. ad95df2 Const police raid. by Steve Bavin · 16 years ago
  89. 327f845 remove the 2nd last evil use of ata_disk_is_active() in apps/ by Jonathan Gordon · 16 years ago
  90. 2843469 Moved atoi declaration to stdlib.h. Deleted atoi.h by Bertrik Sikken · 16 years ago
  91. 3e98eb2 Renamed remove_all_tracks to playlist_remove_all_tracks to make it consistent with the naming of the other functions in playlist.c by Bertrik Sikken · 16 years ago
  92. 0840e1b Remove unused playlist_checkend(), it really should never be needed. by Steve Bavin · 17 years ago
  93. 6ff8f6a Use file_exists instead of duplicating what it does. by Nicolas Pennequin · 17 years ago
  94. 03b54c2 Fix for FS#8601 by pondlife: the disk no longer spins up on a track change when dircache is disabled. This issue was introduced by me in r16019 by adding a call to playlist_peek() in audio_check_new_track(). This fix adds a new playlist API call to work around the problem until we find a better solution. There are also a few simplifications and comment corrections. by Nicolas Pennequin · 17 years ago
  95. 43df837 remove some really old and out of date code... (drawing API changed about 3 times since this code was last touched) by Jonathan Gordon · 17 years ago
  96. ca243ce Fix FS#5797 (Codec failure with directory skip when in file browser, with dircache enabled). Marking the tree context to be reloaded too early would cause the new playlist to contain files that don't exist (correct directory but wrong filenames), in turn causing the codec failures. The fix is to call reload_directory() after the playlist has been created. by Nicolas Pennequin · 17 years ago
  97. 6e06825 Improve insert of playlists. Decode M3U files using current code page and strip any BOM. Also remove a few tabs. by Magnus Holmgren · 17 years ago
  98. ccbe242 Factor out some common code, for simplicity (I hope...) and to save size. by Magnus Holmgren · 17 years ago
  99. 32a9575 FS#7994 - Rename talk.c API, make talk_disable() affect all talking (not just menus), hopefully save some space. by Steve Bavin · 17 years ago
  100. a9b2fb5 Finally full multicore support for PortalPlayer 502x targets with an eye towards the possibility of other types. All SVN targets the low-lag code to speed up blocking operations. Most files are modified here simple due to a name change to actually support a real event object and a param change to create_thread. Add some use of new features but just sit on things for a bit and leave full integration for later. Work will continue on to address size on sensitive targets and simplify things if possible. Any PP target having problems with SWP can easily be changed to sw corelocks with one #define change in config.h though only PP5020 has shown an issue and seems to work without any difficulties. by Michael Sevakis · 17 years ago