Gitiles
Code Review Sign In
gerrit.rockbox.org / rockbox / f06c98fec82e8c800e09603f3022676dbbfdd84b / apps / gui
  1. f06c98f Fix FS#10617 (fix spotted by Teruaki Kawashima), something about the %C not working if %?C is the first tokens in the skin by Jonathan Gordon · 15 years ago
  2. 436776e redraw the AA much less frequently to save bettery life and also let skins draw over the AA... by Jonathan Gordon · 15 years ago
  3. 22933cc FS#10636: Quickscreen incorrect operation when menu has negative step by Jeffrey Goode · 15 years ago
  4. 69b40e7 Clean up duplicate #includes by Bertrik Sikken · 16 years ago
  5. 340f323 new skin tag: %Sx|<english>| will display the current languages translation of the "<english>" string. by Jonathan Gordon · 16 years ago
  6. ba8fbb0 Rename struct skin_albumart members to be consistent with similar members of other structs. the albumart_ prefix is redundant. by Thomas Martitz · 16 years ago
  7. d045f59 Redo 22825 but this time with caring about alignment. by Thomas Martitz · 16 years ago
  8. 4eee66a r22826 is causing data aborts when the wps is loaded in the parse_list function - suspected reason is an improperly aligned pointer depending on how the buffer gets setup when translating a "d". by Karl Kurbjun · 16 years ago
  9. 89041f6 Remove some some code in favor of a single parse_list() call. by Thomas Martitz · 16 years ago
  10. 4ce1604 Show the name of the setting in the WPS debug output by Alexander Levin · 16 years ago
  11. 6622c60 add the %St setting to the debug output for checkwps/parser.... needs mroe work to make it more useful by Jonathan Gordon · 16 years ago
  12. b04c66e Fix splash on charcell (was wasting 2 precious chars per line since r20870). This fixes the volume splash in wps, as it doesn't wrap anymore, but it's not a proper fix. The real problem is that the 2nd line of the default WPS updates immediately. The ultimate fix would be to get rid of the special charcell handling and use a VP in the WPS. by Jens Arnold · 16 years ago
  13. 05fd9ee Actually fix AA display... previous commit was borked by Jonathan Gordon · 16 years ago
  14. 6d16d1c FS#10602 - show the viewport label instead of an int in the debug output by Jonathan Gordon · 16 years ago
  15. aafeaad fix FS#10599 and do r22721 a slightly better way. the %C tag is internally converted to a different token for display and conditional check. by Jonathan Gordon · 16 years ago
  16. 7b6265e Fix a bug where the conditional use of %C (i.e. %?C) caused the album art to draw (noticed in FS#10596). by Thomas Martitz · 16 years ago
  17. 5bd3b44 Fix delay when seeking using the touchscreen by adding a pause/unpause. by Rob Purchase · 16 years ago
  18. c0f1c49 Get rid of some of the code duplication from checkwps, it still duplicates a lot though. by Thomas Martitz · 16 years ago
  19. 541dd6f Remove some trailing whitespaces in in the skin engine files. by Thomas Martitz · 16 years ago
  20. 894c809 Fix/band aid the freeze when %V is the first thing (i.e. in line 1) in a .wps (see FS#10596). by Thomas Martitz · 16 years ago
  21. 65fff8b Increase skin buffer on charcell displays so it's actually big enough to load a wps file by Frank Gevaerts · 16 years ago
  22. 246e38e Initialize token before using. by Teruaki Kawashima · 16 years ago
  23. 8761d9e Hopefully make the wps debug info more understandable... display tokens the same way they are displayed... i.e viewports->lines->sublines->tokens by Jonathan Gordon · 16 years ago
  24. d264556 fix the first subline not displaying properly by Jonathan Gordon · 16 years ago
  25. 1f10f99 Fix/commit FS#10595. A (sub)line could be part of the previous viewport due to a off-by-one bug in the indexing. by Thomas Martitz · 16 years ago
  26. 3234018 Fix viewport_set_defaults giving the wrong dimensions if the ui vp is overridden (as done in plugins atm), and notify other code if the ui vp was overridden. by Thomas Martitz · 16 years ago
  27. 649b50c Set list_need_reinit to false somewhere too. by Thomas Martitz · 16 years ago
  28. 2eb1cb6 Fix buttonbar handling/theme changed handling in lists. by Thomas Martitz · 16 years ago
  29. 18286d3 stupid yellow.... I'm going to bed by Jonathan Gordon · 16 years ago
  30. 8bf50ec add a bit more debug info for skins... show the subimage id in the display image token's debug line by Jonathan Gordon · 16 years ago
  31. fe2f042 rework AA load/display handling in the skins to get them working in viewports again by Jonathan Gordon · 16 years ago
  32. ef7018a fix red :) by Jonathan Gordon · 16 years ago
  33. 9f4f5db Make the e200 compile the vled for the sim... other targets are probably doing the same thing so find out which.. commit will be immediatly followed to fixd red by Jonathan Gordon · 16 years ago
  34. c17037a Factor out/generalise the function that checks whether a point is within a viewport to, and use it in the wps' touchregion code. This corrects the check that was done there. by Thomas Martitz · 16 years ago
  35. a17d06c Improve and simplify touchscreen handling of the quickscreen in absolut mode - and implement handling for the top item. by Thomas Martitz · 16 years ago
  36. 9c938a2 Don't forget the touchscreen targets! by Thomas Martitz · 16 years ago
  37. 4034e0b Put the quickscreen viewports onto the stack (saving a tiny bit of ram), and simplify the preparing and drawing functions a bit. by Thomas Martitz · 16 years ago
  38. dee9277 Fix FS#9842 by stopping scrolling before leaving the yesno screen. by Thomas Martitz · 16 years ago
  39. 42e6638 Fix bug in viewports preparation (screen.lcdwidth() isn't really proper for this in times of custom ui vp), and stop all scrolling before exiting (fixes FS#10584). by Thomas Martitz · 16 years ago
  40. 3c47d94 Alright, it seems I got scroll_stop() wrong. Using the viewport that's set before doing all the puts_scroll* calls seems to work. by Thomas Martitz · 16 years ago
  41. d466cb9 minor line handling fixes, be smarter (well dumber actually) about increasing the size of the tokens array, that loop isnt the only place the data->num_tokens variable gets increased... also add one last WPS_NO_TOKEN token to the end to make sure we dont accidently overrun into the next skin on the last line of a skin. by Jonathan Gordon · 16 years ago
  42. 2512357 Fix STRIDE macro for multiscreen and add stride support for picture lib. by Karl Kurbjun · 16 years ago
  43. f602518 stop a potential crash caused by r22438 by Jonathan Gordon · 16 years ago
  44. 2ab627d Change r22610 a bit. The new parent viewport isn't really suitable. by Thomas Martitz · 16 years ago
  45. af2dcbb Don't stop scrolling for the whole display, but only in the actual list parent viewport. by Thomas Martitz · 16 years ago
  46. 8f76e7f rename wps_[sub]line to skin_[sub]line by Jonathan Gordon · 16 years ago
  47. 2111c10 fix player's red by Jonathan Gordon · 16 years ago
  48. 8cb7443 Almost the last of the skin ram wastage fixing... This one moved the line/subline handling into the alloced buffer and links them more sensibly with their viewports. by Jonathan Gordon · 16 years ago
  49. 9b700b2 Added a missing line for spoken QUICKSCREEN_TOP item in Quick Screen. by Alessio Lenzi · 16 years ago
  50. 7bb7c5f Add stride defines to support vertical strides by Karl Kurbjun · 16 years ago
  51. dd5789b Respect UI viewport per screen in viewport_set_defaults() also. by Thomas Martitz · 16 years ago
  52. 5b2a599 fix FS#10465 and return GO_TO_ROOT instead of SYS_USB_CONNECTED in gui_wps_show. by Teruaki Kawashima · 16 years ago
  53. 90a29dd Make UI viewport handling more multiscreen aware and bring a break; accidentally back lost in a previous commit (r22485). by Thomas Martitz · 16 years ago
  54. e454a39 Quickscreen: 4th item by Thomas Martitz · 16 years ago
  55. 3598eb0 Do some #ifdef'ing to make the Player happy. by Thomas Martitz · 16 years ago
  56. af967d7 Fix skin engine calling wps code to draw the statusbars (add a pointer to viewportmanager-suitable statusbar values, which are the same for all screens), and re-arrange statusbar related code slightly. No functional change. by Thomas Martitz · 16 years ago
  57. 3460ef3 Make sure that skin_buffer.c #includes its own skin_buffer.h by Bertrik Sikken · 16 years ago
  58. 5850207 Slightly change parts of the previous commit to reuse existing code, and enforce enum statusbar_values instead of just int, by Thomas Martitz · 16 years ago
  59. 19f44a6 Fix redraw issues when the statusbar setting was changed with an UI viewport. Now the old statusbar area is cleared upon changing the setting. by Thomas Martitz · 16 years ago
  60. 3aa738f hopefully get the widecabbie theme going again... temporary fix only though by Jonathan Gordon · 16 years ago
  61. 94419e9 Touchscreen list handling: use icon width instead of scrollbar width for the 'ignoring' zone + correct comment that shouldn't be true anymore (and never was AFAIK) by Maurus Cuelenaere · 16 years ago
  62. 4ce82b9 Touchscreen list handling: ignore presses close to the scrollbar when it's on the right, this is similar as how it's handled when the scrollbar is on the left (icons) and improves user experience due to touchscreen dead zones. by Maurus Cuelenaere · 16 years ago
  63. 07b2708 Touchscreen list handling: fix issue where scrolling with the scrollbar could bring up the context menu for an item by Maurus Cuelenaere · 16 years ago
  64. 876db6c Fix/hack checkwps + add Onda VX747/VX777 targets by Maurus Cuelenaere · 16 years ago
  65. 3200d04 Make the formatter functions used by the settings return a pointer to avoid usless copying of lang strings, this brought with it a long chain of const correctness and a few random cleanups by Nils Wallménius · 16 years ago
  66. e510de1 Move handling of "rockbox_default.[r]wps" into wps.c, out of the skin engine (which should be as generic as possible). by Thomas Martitz · 16 years ago
  67. 5b349e3 update the display after getting a bit too close to the touchscreen instead of just asking it nicely to change volume! by Jonathan Gordon · 16 years ago
  68. 4f87976 Slight cleanup in lcd.h: kill fixme and remove useless include, add some includes elsewhere and add a stub for sims instead of ifdef by Nils Wallménius · 16 years ago
  69. 23e534d Delete the trivial comment by Alexander Levin · 16 years ago
  70. 07d0bfd Combine the settings for scrollbar on/off and its position into one with three possible values by Alexander Levin · 16 years ago
  71. afd8c2d hopefully fix the yellow by Jonathan Gordon · 16 years ago
  72. c552d08 get the skin debug output working again, add a line to say how much of the buffer is being used to aid themers... let me know if this gets close to full on any targets by Jonathan Gordon · 16 years ago
  73. 98756fe move the statically allocated tokens array into the skin buffer. this is done with a little bit of magic with the buffer... explanation in the comments but breifly, tokens + images are stored at the front of the buffer, everything else (constant sizes) are stored at the back, the 2 ends meet when the buffer is full. by Jonathan Gordon · 16 years ago
  74. 2492e25 conditional viewports are allowed to share labels.. so make sure they are all toggled with %xd<label> by Jonathan Gordon · 16 years ago
  75. ae901c2 Scrollbar position: only update it when exiting the menu + FS#10539 by Alexander Levin (change the order of Left/Right) by Maurus Cuelenaere · 16 years ago
  76. dab7e16 store the image label instead of a number so debug output is actually useful when %xd is used witout a coresponding %xl by Jonathan Gordon · 16 years ago
  77. 36ca496 move viewports into the skin buffer, no more viewport limit on the skin by Jonathan Gordon · 16 years ago
  78. f451108 M:Robe 500: Increase the max icon size. by Karl Kurbjun · 16 years ago
  79. daaecb9 Add setting to position the scrollbar on the left or right by Maurus Cuelenaere · 16 years ago
  80. 567d83e FS#10534: Make scrollbar width variable through a setting (useful for touchscreen targets) by Maurus Cuelenaere · 16 years ago
  81. 8d013f5 Skin engine: add "pitch" action to touch regions by Maurus Cuelenaere · 16 years ago
  82. 91aa512 fix the %xd<id> tag parser to complain if you try to display an image it hasnt loaded yet by Jonathan Gordon · 16 years ago
  83. be8d654 Remove obsolete IMG_BUFSIZE #define. by Thomas Martitz · 16 years ago
  84. f1c704e Fix ret for buttonbar targets. by Thomas Martitz · 16 years ago
  85. 4c48b59 User definable UI viewport, to be able to restrict the UI into a viewport for all bitmap displays. by Thomas Martitz · 16 years ago
  86. b395f89 remove an unused #define by Jonathan Gordon · 16 years ago
  87. 271643c remove the limit of touch regions in touchscreen skins by Jonathan Gordon · 16 years ago
  88. 576793a Recalibrate the skin buffer size calculation so that targets with remote get a reasonable extra buffer (depending on the remote) instead of just doubling it. by Thomas Martitz · 16 years ago
  89. c20801b fix player by Jonathan Gordon · 16 years ago
  90. 18a8e52 more wps->skin engine work.. by Jonathan Gordon · 16 years ago
  91. 279ef75 Make quickscreen items enum name lower-case, as per docs/CONTRIBUTING. by Thomas Martitz · 16 years ago
  92. 20b9bc5 Make gui_syncquickscreen_run() static as it's not used anywhere. by Thomas Martitz · 16 years ago
  93. 7b6e166 Protect viewport.h against multiple inclusion. by Thomas Martitz · 16 years ago
  94. 3bfc0e7 Remove unneeded symbols and improve the comment to the VP parsing function by Alexander Levin · 16 years ago
  95. e4bdc08 Fix FS#10505 - "Background changes to inverted when cleared" as well as a problem that lets the viewport parser reject correct WPSes, both introduced by r22222 by Thomas Martitz · 16 years ago
  96. 1c0aeb1 r22135 overwrote mcuelenaere's changes in r22068 to add slider-type regions for the touchscreen... so bring them back (spotted by kkurbjun) by Jonathan Gordon · 16 years ago
  97. a1b0e16 Don't set the drawmode twice and simplify two cases in viewport_parse_viewport. by Thomas Martitz · 16 years ago
  98. f909428 Fix the yellows. by Thomas Martitz · 16 years ago
  99. 9f3fc27 Fix player and greyscale reds. by Thomas Martitz · 16 years ago
  100. dc4e903 r22135 overwrote mcuelenaere's changes in r22068 to add slider-type regions for the touchscreen... so bring them back (spotted by kkurbjun) by Jonathan Gordon · 16 years ago